feat: use go-git index instead of git ls-files #23

brianmcgee · 2024-01-12T09:39:58Z

brianmcgee commented

2024-01-12 09:39:58 +00:00

Figured out how to use go-git properly.

# git

❯ nix run .# -- --config-file ./test/echo.toml --tree-root /home/brian/Development/com/github/nixos/nixpkgs -c
38539 files changed in 272.843495ms

# filesystem

❯ nix run .# -- --config-file ./test/echo.toml --tree-root /home/brian/Development/com/github/nixos/nixpkgs -c --walk filesystem
38567 files changed in 348.84277ms

Signed-off-by: Brian McGee brian@bmcgee.ie

Figured out how to use `go-git` properly. ```console # git ❯ nix run .# -- --config-file ./test/echo.toml --tree-root /home/brian/Development/com/github/nixos/nixpkgs -c 38539 files changed in 272.843495ms # filesystem ❯ nix run .# -- --config-file ./test/echo.toml --tree-root /home/brian/Development/com/github/nixos/nixpkgs -c --walk filesystem 38567 files changed in 348.84277ms ``` Signed-off-by: Brian McGee <brian@bmcgee.ie>

brianmcgee added 1 commit 2024-01-12 09:39:58 +00:00

feat: use go-git index instead of git ls-files a20b8c7645

Signed-off-by: Brian McGee <brian@bmcgee.ie>

brianmcgee requested review from zimbatm 2024-01-12 09:40:04 +00:00

zimbatm approved these changes 2024-01-12 11:07:52 +00:00

zimbatm left a comment

yup, less concurrency is good.

I'm curious, did you compare the perfs between the native and Go implementations of Git?

yup, less concurrency is good. I'm curious, did you compare the perfs between the native and Go implementations of Git?

brianmcgee commented

2024-01-12 11:33:04 +00:00

I'm curious, did you compare the perfs between the native and Go implementations of Git?

Nope, worth doing at some point though.

> I'm curious, did you compare the perfs between the native and Go implementations of Git? Nope, worth doing at some point though.

brianmcgee merged commit 80e99b6d75 into main

2024-01-12 11:33:15 +00:00

brianmcgee referenced this issue from a commit

2024-01-12 11:33:16 +00:00

feat: use go-git index instead of `git ls-files` (#23)

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: numtide/treefmt#23

feat: use go-git index instead of git ls-files #23

feat: use go-git index instead of `git ls-files` #23